Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: max accounts dialog prevent dismiss (WPB-4818) #2260

Merged
merged 1 commit into from
Sep 22, 2023
Merged

fix: max accounts dialog prevent dismiss (WPB-4818) #2260

merged 1 commit into from
Sep 22, 2023

Conversation

yamilmedina
Copy link
Contributor

PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³

  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

Dialog can be dismissed bypassing the max accounts creation.

Causes (Optional)

Max accounts flag not respected

Solutions

Make the dialog stick, not dismiss outside.

PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.
References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@yamilmedina yamilmedina self-assigned this Sep 22, 2023
@yamilmedina yamilmedina requested review from alexandreferris, gongracr, a team, MohamadJaara, vitorhugods and Garzas and removed request for a team September 22, 2023 12:58
alexandreferris
alexandreferris approved these changes Sep 22, 2023
View reviewed changes
Copy link
Contributor

@alexandreferris alexandreferris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

an easy miss 😅

@yamilmedina yamilmedina enabled auto-merge (squash) September 22, 2023 13:02
@yamilmedina yamilmedina merged commit b4f76b7 into release/candidate Sep 22, 2023
7 checks passed
@yamilmedina yamilmedina deleted the fix/max-accounts-dialog branch September 22, 2023 13:18
github-actions bot pushed a commit that referenced this pull request Sep 22, 2023
@yamilmedina @github-actions
fix: max accounts dialog prevent dismiss (WPB-4818) (#2260)
44a4c5b
@github-actions github-actions bot mentioned this pull request Sep 22, 2023
Closed
6 tasks
@github-actions
Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

@AndroidBob
Copy link
Collaborator

Build 914 succeeded.

The build produced the following APK's:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ohassine ohassine ohassine approved these changes

@alexandreferris alexandreferris alexandreferris approved these changes

@gongracr gongracr Awaiting requested review from gongracr

@MohamadJaara MohamadJaara Awaiting requested review from MohamadJaara MohamadJaara was automatically assigned from wireapp/android

@vitorhugods vitorhugods Awaiting requested review from vitorhugods vitorhugods was automatically assigned from wireapp/android

@Garzas Garzas Awaiting requested review from Garzas Garzas was automatically assigned from wireapp/android

Assignees

@yamilmedina yamilmedina

Labels
size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yamilmedina @AndroidBob @alexandreferris @ohassine